Skip to content

pkg/cli/admin/release/extract_tools: Drop AsArchive from extractTarget #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wking wants to merge 1 commit into from
Closed

pkg/cli/admin/release/extract_tools: Drop AsArchive from extractTarget #175

wking wants to merge 1 commit into from

Conversation

@wking
Copy link
Member

@wking wking commented Nov 20, 2019

This is a per-extraction-call setting, not a per-extracted-target setting. Targets for a given extraction call are either going to be all archives or never archives. AsArchive landed in openshift/origin@a63351b9bb (openshift/origin#22439).

Dropping the AsZip bit of the loop is fine because we are hard-coding AsZip true for the Windows oc in the initial availableTargets declaration.

@wking
pkg/cli/admin/release/extract_tools: Drop AsArchive from extractTarget
77a47f1 
This is a per-extraction-call setting, not a per-extracted-target
setting.  Targets for a given extraction call are either going to be
all archives or never archives.  AsArchive landed in
openshift/origin@a63351b9bb (release: Support extracting the 'oc' and
'openshift-install' binaries, 2019-03-30, openshift/origin#22439).

Dropping the AsZip bit of the loop is fine because we are hard-coding
AsZip true for the windows oc in the initial availableTargets
declaration.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 20, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
To complete the pull request process, please assign deads2k
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 23, 2020

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 23, 2020
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 5, 2020

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-cmd 77a47f1 link /test e2e-agnostic-cmd
ci/prow/e2e-aws-serial 77a47f1 link /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 6, 2020

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2020

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@tnozicka tnozicka Awaiting requested review from tnozicka

Assignees

No one assigned

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wking @openshift-ci-robot @openshift-bot @openshift-merge-robot